Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improv: Berry Bushes now work with fast graphics #2116

Merged
merged 4 commits into from
Apr 17, 2024
Merged

improv: Berry Bushes now work with fast graphics #2116

merged 4 commits into from
Apr 17, 2024

Conversation

bconlon1
Copy link
Contributor

@bconlon1 bconlon1 added the status/pending-review The issue references a pull request which is pending review. label Apr 17, 2024
@bconlon1 bconlon1 self-assigned this Apr 17, 2024
@mrjasonn
Copy link
Contributor

Just a quick question: does this just datagen a fixed texture image file?

@bconlon1
Copy link
Contributor Author

This PR has changed texture files, changed datagenned models, and a new model class registered in the file diff.

OscarPayn
OscarPayn approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@OscarPayn OscarPayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bconlon1 bconlon1 merged commit ad6381d into 1.20.4-develop Apr 17, 2024
2 checks passed
@bconlon1 bconlon1 deleted the feat/bconlon/fast-bush branch April 17, 2024 23:27
@mrjasonn
Copy link
Contributor

mrjasonn commented Apr 18, 2024 •
edited

This PR has changed texture files, changed datagenned models, and a new model class registered in the file diff.

What does the new model class do? @bconlon1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OscarPayn OscarPayn OscarPayn approved these changes

Assignees

@bconlon1 bconlon1

Labels
status/pending-review The issue references a pull request which is pending review.
Projects
The Aether
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bconlon1 @mrjasonn @OscarPayn