Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript support #9

Closed
The-CodingSloth opened this issue Sep 2, 2023 · 3 comments · Fixed by #31
Closed

Add TypeScript support #9

The-CodingSloth opened this issue Sep 2, 2023 · 3 comments · Fixed by #31

Comments

@The-CodingSloth
Copy link
Owner

The-CodingSloth commented Sep 2, 2023

Currently using JavaScript throughout this whole extension and that's some Junior Developer behavior. TypeScript support would help a lot and make this look more professional because we're all 10x developers here.

Here's a link for chrome type package to get started:
chrome type package

@slav-getov
Copy link

Hey, idk if this was intentional but the link you provided does not actually lead to where you want - it leads to: 'https://github.com/The-CodingSloth/haha-funny-leetcode-extension/issues/url'.

Anyways, for anyone else interested @The-CodingSloth wanted to link here. Thank you for making that video on the extension!

@The-CodingSloth
Copy link
Owner Author

haha thanks so much I'm dumb sometimes

green1490 added a commit to green1490/haha-funny-leetcode-extension that referenced this issue Sep 8, 2023
@green1490
Copy link
Contributor

green1490 commented Sep 8, 2023

I rewrote the codebase into typescript besides the test scripts. The only thing that is left is to handle undefined cases to reduce the spaghetti.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants