Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatting issues on tiptap editor #869

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

prathameshkurunkar7
Copy link
Contributor

As per the issues mentioned above, here are the changes made:

Solutions:

  1. Added support for Inline Code, another button which lets you add inline code and render's it similarly.
  2. Code Block takes up entire text instead of the current line is fixed by allowing Shift + Enter to add soft line breaks, which would make the node as separate paragraph tags which in turn allows us to add code block to particular line instead of entire text block. Moreover discovered that 3 times press Enter inside CodeBlock would allow us to escape it as well.
  3. Link was extensible but fixed it by referring to the solution mentioned in the thread. After inserting the link, all words are also part of the link ueberdosis/tiptap#2571
  4. Upgraded the TipTap packages to latest version.

Also close #733 as it was solved earlier.

@nikkothari22 nikkothari22 merged commit 5b266a3 into develop Apr 12, 2024
2 of 3 checks passed
@nikkothari22 nikkothari22 deleted the 866-fix-formatting-issues-on-tiptap-editor branch April 12, 2024 14:36
@prathameshkurunkar7 prathameshkurunkar7 restored the 866-fix-formatting-issues-on-tiptap-editor branch April 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix formatting issues on Tiptap editor Highlight Issue
2 participants