Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: animation timing and layout shifting #902

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: animation timing and layout shifting #902

merged 1 commit into from
May 3, 2024

Conversation

nikkothari22
Copy link
Member

  1. Added new animation timing functions for hover and loading.
  2. Avoid layout shift in sidebar - pre-calculate the height of the sidebar sections if possible (data is cached anyway)
  3. Remove lazy loading of Tiptap editor - we need it anyway

Before (layout shifts even with caching):

Export-1714745174751

After (almost no layout shift):
Export-1714745230656

Next steps:

  1. Remove network request waterfall
  2. Use skeleton loader or just the Raven logo for the main full page loader (splash screen)

@nikkothari22 nikkothari22 merged commit ed9addb into develop May 3, 2024
3 checks passed
@nikkothari22 nikkothari22 deleted the fix-animations branch May 3, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💻 webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nikkothari22