Skip to content
This repository has been archived by the owner on Jun 13, 2022. It is now read-only.

#3 - IMPROVEMENT: Create script for fixing video resources on mobile #35

Merged
merged 5 commits into from
Oct 3, 2020

Conversation

karx1
Copy link
Member

@karx1 karx1 commented Oct 2, 2020

Your PR should be for a corresponding issue. If the issue doesn't exist yet, create that issue and mention the issue in your PR.

Add one of the following prefixes for your PR:

  • [ [ISSUE-LABEL] - FEATURE ]
  • [ [ISSUE-LABEL] - FIX ]
  • [ [ISSUE-LABEL] - IMPROVEMENT ]

Your PR should contain a description of the changes you made.
The description should be within 250 words. Please try to follow this word limit.

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

Am I familiar with the tech stack of this project? (Important for PRs that have code changes)

  • Yes
  • No.

If yes, please mention the back-end framework used in this project. - Python Django

Have I contributed before to DomeCode? (req.)

  • Yes, once.
  • Yes, more than once but not a lot.
  • Yes, extensively.
  • No.

Have I used DomeCode? (req.)

  • Not a lot.
  • Extensively.
  • Nope.

This script will automatically detect videos in resources, and apply special CSS in order to fix the videos.
This is done with JavaScript and a CSS wrapper.

This PR partially addresses #3.

I have tested that the script works as intended and correctly applies the fix for each video
in the resource, even if there are multiple.

@karx1 karx1 requested a review from arthtyagi as a code owner October 2, 2020 20:06
@karx1
Copy link
Member Author

karx1 commented Oct 2, 2020

Here's a screenshot of what the script does.

resources

@arthtyagi
Copy link
Member

This looks promising in my opinion.

@arthtyagi arthtyagi merged commit 6b119c0 into The-Domecode:dev Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants