Skip to content
This repository has been archived by the owner on Jun 13, 2022. It is now read-only.

#37 - FIX: Modify fusion to extend base.html #38

Merged
merged 2 commits into from
Oct 9, 2020
Merged

#37 - FIX: Modify fusion to extend base.html #38

merged 2 commits into from
Oct 9, 2020

Conversation

karx1
Copy link
Member

@karx1 karx1 commented Oct 7, 2020

Your PR should be for a corresponding issue. If the issue doesn't exist yet, create that issue and mention the issue in your PR.

Add one of the following prefixes for your PR:

  • [ [ISSUE-LABEL] - FEATURE ]
  • [ [ISSUE-LABEL] - FIX ]
  • [ [ISSUE-LABEL] - IMPROVEMENT ]

Your PR should contain a description of the changes you made.
The description should be within 250 words. Please try to follow this word limit.

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

Am I familiar with the tech stack of this project? (Important for PRs that have code changes)

  • Yes
  • No.

If yes, please mention the back-end framework used in this project. - Python Django

Have I contributed before to DomeCode? (req.)

  • Yes, once.
  • Yes, more than once but not a lot.
  • Yes, extensively.
  • No.

Have I used DomeCode? (req.)

  • Not a lot.
  • Extensively.
  • Nope.

This PR addresses #37.

This makes the Fusion Immerse editor extend base.html.
This is needed so that the bottom footer and other elements on the page can follow
the global style. Merging this PR will help prevent the code from becoming
unmaintainable.

@karx1 karx1 requested a review from arthtyagi as a code owner October 7, 2020 22:40
@arthtyagi arthtyagi merged commit 5bf65e6 into The-Domecode:dev Oct 9, 2020
@arthtyagi
Copy link
Member

arthtyagi commented Oct 10, 2020

image
Remove the white space in there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants