Update to Rack v2 API #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed JSON Methods from `ModuleWidget` subclass, these were deprecated and removed. If you need to use them, use `Engine::fromJson` or `RackWidget::fromJson` - It looks like maybe since your plugin doesn't involve any processing from the engine (just artwork), then you may not need these methods at all. - The `release()` method from `MFTexture` is currently causing VCV Rack to crash right before the program is closed due to unallocated memory issues. Will try to address this in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Rack v2 API - Repair/migration - VCVRack/library#591
Removed JSON Methods from
ModuleWidgetsubclass,these were deprecated and removed. If you need to use them, use
Engine::fromJsonorRackWidget::fromJsonIt looks like maybe since your plugin doesn't involve any processing from the engine (just artwork), then you may not need these methods at all.
The
release()method fromMFTextureis currently causing VCV Rack to crash right before the program is closed due to unallocated memory issues. Will try to address this in the next commit.