Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send /module/new when meow module changed #11

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rjsmith
Copy link

@rjsmith rjsmith commented Jul 8, 2023

Fixes #9

Summary of changes:

  • New /module/new OSC messages sent when switching meow modules
  • Updated documentation
  • Module version bump

@rjsmith
Copy link
Author

rjsmith commented Jul 8, 2023

Hi @The-Modular-Mind - I would appreciate your feedback on this first draft merge request. Testing it with my TouchOSC template now.

@The-Modular-Mind
Copy link
Owner

Hey RJ, sorry I didn't get back to this, I did makes some changes per your requests, I'll clean that up and post a test build today, let's follow up on this after.

@The-Modular-Mind
Copy link
Owner

Hey can you try the build from here and lmk:
https://github.com/The-Modular-Mind/oscelot/releases/tag/latest

You'll see messages like this:

{ address: '/oscelot/moduleMeowMory/start', args: [ 'VCF', 'VCV VCF', 'Voltage-controlled filter', 7 ] }
...
...
{ address: '/oscelot/moduleMeowMory/end', args: 7 }
{ address: '/oscelot/bankMeowMory/start', args: 7 }
...
...
{ address: '/oscelot/bankMeowMory/end', args: 7 }

@rjsmith
Copy link
Author

rjsmith commented Jul 17, 2023 via email

@rjsmith
Copy link
Author

rjsmith commented Jul 17, 2023

Hi - your test build works well, thanks very much.

@rjsmith
Copy link
Author

rjsmith commented Aug 5, 2023

HI - I have done some more testing, and realised that your proposed message is missing the same module name that is sent on the /fader/info message. My TouchOSC script needs that same string to match the info messages to the module:

RECEIVE    | ENDPOINT([::ffff:127.0.0.1]:49240) ADDRESS(/oscelot/moduleMeowMory/start) STRING(Bogaudio-AddrSeq) STRING(Bogaudio ADDR-SEQ) STRING(Voltage-addressable 8-step sequencer) INT32(10)
RECEIVE    | ENDPOINT([::ffff:127.0.0.1]:49240) ADDRESS(/fader) INT32(1) FLOAT(0)
RECEIVE    | ENDPOINT([::ffff:127.0.0.1]:49240) ADDRESS(/fader/info) INT32(1) STRING(ADDR-SEQ) FLOAT(0.5) STRING(Step 1) STRING(-10) STRING( V)

In the example above, the /start message needs the "ADDR-SEQ" string as an additional argument, or change the 2nd argument to just "ADDR_SEQ". Or maybe even change the /fader/info 2nd argument to match the 2nd argument of the /start message.

@The-Modular-Mind
Copy link
Owner

Will fix this in the next build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Send OSC marker message when changing mapped module
2 participants