Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Configuration File via HTTPS #25

Open
gianlucafrei opened this issue Dec 6, 2020 · 3 comments
Open

Load Configuration File via HTTPS #25

gianlucafrei opened this issue Dec 6, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers Version 1.0

Comments

@gianlucafrei
Copy link
Collaborator

Currently we Nelly only supports to load a config file from the local filesystem. We should add the option to load a configuration file via HTTPS.

-> Add a new class that implements NellyConfigLoader that load the file via https from remote
-> Implement the HTTP loading if the file path begins with https://
-> Add error handling

@gianlucafrei gianlucafrei added enhancement New feature or request good first issue Good for newcomers labels Dec 6, 2020
@nbaars
Copy link

nbaars commented Sep 4, 2021

Maybe integrate with Spring Cloud Config server? (https://cloud.spring.io/spring-cloud-config/reference/html/)

@gianlucafrei
Copy link
Collaborator Author

@nbaars Seems like a good idea, however, only HTTPS is way simpler. Can Spring Cloud Config host our custom YAML file?

@nbaars
Copy link

nbaars commented Sep 24, 2021

Yes, by default it will use a Git repo it will checkout but you can also define a different backend, for example: Vault, file, JDBC etc etc, see: https://cloud.spring.io/spring-cloud-config/multi/multi__spring_cloud_config_server.html#_file_system_backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Version 1.0
Projects
None yet
Development

No branches or pull requests

2 participants