Make LDTC copy BIZR, BIZRG and BIZRG's wavelength too. #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the identifiers
|
if i might comment on this, one thing to note is that C5 is also coded to have a wavelength (it uses it to store the value of PHOT when it passes through it), though i'm not sure when using LDTC on C5 would be useful really glad this is being implemented though (or at least being considered for implementation), i've been wanting BIZR-LDTC interaction for a while now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently DTEC got updated to detect the wavelenghts of the elements mentioned in the title. This PR adds that missing ability to LDTC element aswell.