107 v6 framework #108
Merged
107 v6 framework #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in preprocessing due to missing values in q_type
…of whether text is preprocessed
|
😢 forgot that some of the data used for testing has hardcoded column headings... will need to amend the test data, ideally in a way that is flexible ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107
Minor improvement such as ensuring train_test_split random_state produces exactly the same splits for all model types, previously this was not the case as there was some extra text cleaning that happened with sklearn models which dropped additional rows.
minor_cats in params file now 44 items long, reflecting size of v6 framework