Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar and future-proof against new releases #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

soulofmischief
Copy link

There was a grammatical redundancy in the phrase "both the two", so by generalizing the statement to any arbitrary number of .lua files we simultaneously fix this redundancy and future-proof the README against new releases, which might add or subtract a script file.

There was a grammatical redundancy in the phrase "both the two", so by generalizing the statement to any arbitrary number of .lua files we simultaneously fix this redundancy and future-proof the README against new releases, which might add or subtract a script file.
@Hrxn
Copy link

Hrxn commented Mar 16, 2019

Not sure if trolling...

@soulofmischief
Copy link
Author

Why would I be trolling? I plan to submit a few PRs and this was the lowest hanging fruit. Documentation improvements, however trivial, should be welcome.

@Hrxn
Copy link

Hrxn commented Mar 16, 2019

It's ultimately not my decision, but improvements are generally welcome, I'm sure.
But things like second-person reference (2nd commit), I mean, that is not even wrong. Purely stylistic change.

@soulofmischief
Copy link
Author

Sure, but that wasn't the point or title of my commit. I simply improved upon the original commit before it was accepted. If I had done that beforehand without making two separate commits, you wouldn't have said anything.

You're nitpicking and it's unwelcome, particularly because you're right, it's not your decision at all and you should let the project maintainers make their decision without comments from the peanut gallery.

@garoto
Copy link

garoto commented Mar 16, 2019

Hey buddy, that contrib graph won't get greener by its own, ok? Gimme a break here willya?

@soulofmischief
Copy link
Author

@garoto Are you trying to insinuate something or am I misunderstanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants