Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate soul-event-5 (gun) parameters #127

Open
TheAfroOfDoom opened this issue Jul 15, 2024 · 0 comments
Open

validate soul-event-5 (gun) parameters #127

TheAfroOfDoom opened this issue Jul 15, 2024 · 0 comments
Labels
datapack Issues pertaining to the datapack resourcepack Issues pertaining to the resourcepack validation validation that preexisting features are functioning and appear as clean as possible

Comments

@TheAfroOfDoom
Copy link
Owner

TheAfroOfDoom commented Jul 15, 2024

run the soul event (individually and during a boss fight) and analyze how the following properties feel:

bullet/flower sizes

currently when we summon a bullet/flower (healer), they summon as-is with no animation. they may be a bit small though. in order to increase their size we'd need to add a scale-up animation where they get bigger a couple frames after being shot.

we'd want to increase their size if it's too easy to dodge the bullets / too hard to catch the flowers.

we already do this scale-up animation for the ACT button:

full speed animation
act-button-scale-up-animation
slow motion
act-button-scale-up-animation-slow-motion

# Summon bullet
function animated_java:act_button/summon { args: { animation: 'soul_5', start_animation: true } }

gun rotation speed

the gun rotates towards the crosshair at some speed.

# else, rotate slightly more towards the crosshair
# TODO(131): this is linear but in Undertale it's not so fix that
# here, diff is -180..180
execute unless score @s math.1 matches 1.. run teleport @s ~ ~ ~ ~-9 ~
execute if score @s math.1 matches 1.. run teleport @s ~ ~ ~ ~9 ~

this can be adjusted now (staying linear), but will need to be reconsidered affected if/when #131 is worked on

gun rotation speed post-saved, flower speed, flower spawn radius

we could change these values post-SAVED so that the flowers are easier to catch. maybe not necessary if the flower sizes are increased

general score parameters

there's only two for this soul event:

# TODO(127): validate these soul parameters
# length this soul event will last if the act button is never grabbed
scoreboard players set #soul-5 soul.executor.clock.length 365
scoreboard players set #soul-5 soul.indicator.bullets.total 3

really these should be fine but i'm listing them anyway just in case.

  • soul.indicator.bullets.total is definitely good since the gun in Undertale shoots bullets in triplets
  • soul.executor.clock.length was calculated by counting how many frames until the player is sent back to the Flowey arena if they don't grab the ACT button.
    • (this is currently the same value as soul event 0's soul.executor.clock.length, and likely should stay that way)
@TheAfroOfDoom TheAfroOfDoom added datapack Issues pertaining to the datapack validation validation that preexisting features are functioning and appear as clean as possible labels Jul 15, 2024
@TheAfroOfDoom TheAfroOfDoom added the resourcepack Issues pertaining to the resourcepack label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datapack Issues pertaining to the datapack resourcepack Issues pertaining to the resourcepack validation validation that preexisting features are functioning and appear as clean as possible
Projects
None yet
Development

No branches or pull requests

1 participant