Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add fenwick tree 2D data structure, struct fenwick2D #1230

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 117 additions & 0 deletions range_queries/fenwick_tree_2d.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
#include <iostream>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document the header

#include <cassert>
#include <vector>
Comment on lines +1 to +3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <iostream>
#include <cassert>
#include <vector>
#include <iostream> /// for I/O operations
#include <cassert> /// for assert
#include <vector> /// for std::vector

needs documentation



template <class T>
struct fenwick {
int siz;
std::vector<T> arr;

// Constructor
// n - size of the array on which fenwick tree is used
// creates a new array with all entries as 0
// indicies are 1-indexed
explicit fenwick(int n) {
siz = n;
arr.resize(n + 1);
}

// Calculates a prefix sum till index idx
T sum(int idx) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to check if idx <= siz

T an = 0;
while(idx > 0) {
an += arr[idx];
// subtract first active bit from idx
idx -= idx & -idx;
}
return an;
}

// update the values at idx by delta
// update all the indices which include idx in their sum
void update(int idx, T delta) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly, could check the bounds of idx

while (idx < siz + 1) {
arr[idx] += delta;
// add the first active bit to idx
idx += idx & -idx;
}
}

// find sum in range l to r
T query(int l, int r) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally, here are even more implicit assumptions on the input, 0 < l <= r <= siz (I believe)

return sum(r) - sum(l - 1);
}
};

template<class T>
struct fenwick2D{

int siz;
std::vector<fenwick<T>> arr;

// Constructor
// n - size of the array on which fenwick tree is used
// creates a new array of fenwick trees of size n with all entries 0
// indicies are 1-indexed
explicit fenwick2D(int n) {
siz = n;
arr.resize(n + 1, fenwick<T>(n));
}

// if position x, y needs to be updates
// then go to all fenwick tree which have position x
// and then for each of those fenwick trees make an update at
// position y
void update(int x, int y, T delta) {
while(x < siz + 1) {
arr[x].update(y, delta);
x += x & -x;
}
}

// sum of region {1 to x} and {1 to y}
T sum(int x, int y) {
T an = 0;
while(x > 0) {
// for each fenwick tree in range calucate sum till y
an += arr[x].sum(y);
x -= x & -x;
}
return an;
}

// sum of region {x1 to x} and {y1 to y}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: For clarity, I think it would be better to call them x1, x2 and y1, y2

T query(int x1, int y1, int x, int y) {
return sum(x, y) - sum(x1 - 1, y) - sum(x, y1 - 1) + sum(x1 - 1, y1 - 1);
}

};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* @brief Main function
* @returns 0 on exit
*/

int main() {

int n = 5;

fenwick2D<int> fenwick_tree_2D(n);

fenwick_tree_2D.update(1, 1, 2);
fenwick_tree_2D.update(1, 2, 3);
fenwick_tree_2D.update(2, 1, 3);
fenwick_tree_2D.update(1, 3, 4);
fenwick_tree_2D.update(2, 2, 4);
fenwick_tree_2D.update(3, 1, 4);
fenwick_tree_2D.update(1, 4, 5);
fenwick_tree_2D.update(2, 3, 5);
fenwick_tree_2D.update(3, 2, 5);
fenwick_tree_2D.update(3, 3, 6);

assert(fenwick_tree_2D.query(1, 1, 2, 2) == 12);
assert(fenwick_tree_2D.query(1, 2, 3, 3) == 27);
fenwick_tree_2D.update(1, 1, -3);
assert(fenwick_tree_2D.query(1, 1, 2, 2) == 9);
assert(fenwick_tree_2D.query(1, 2, 3, 3) == 27);

std::cout << "All Test Passed\n";

return 0;
}