Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add CodeQL Analysis workflow #1465

Merged
merged 1 commit into from
Mar 14, 2021
Merged

feat: Add CodeQL Analysis workflow #1465

merged 1 commit into from
Mar 14, 2021

Conversation

Panquesito7
Copy link
Member

Description of Change

  • Add CodeQL Analysis workflow.
    • Replaces LGTM, as LGTM only runs on commits, and CodeQL works faster, too.

Checklist

  • Added description of the change.
  • Added file name matches File name guidelines
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Replaces LGTM, as LGTM only runs on commits, and CodeQL works faster, too.
@Panquesito7 Panquesito7 added the enhancement New feature or request label Mar 13, 2021
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Code scanning ran in 3 sec because it found no results even though Analysis says that it successfully uploaded them.
  2. Let’s lose LGTM
  3. Do we really need to test on Mac, Windows, and Linux? Our tests are heating the planet!
    • Do the three OSes ever disagree on test results?

@ayaankhan98
Copy link
Member

ayaankhan98 commented Mar 13, 2021

  1. Code scanning ran in 3 sec because it found no results even though Analysis says that it successfully uploaded them.

  2. Let’s lose LGTM

  3. Do we really need to test on Mac, Windows, and Linux? Our tests are hearing the planet!

    • Do the three OSes ever disagree on test results?
  1. we can remove Mac if required, because Mac as well as Linux both uses GNU GCC compiler whereas on windows we are using a different implementation of compiler MSVC. Therefore keeping windows along with Linux is neccessary. We can get rid of Mac (incase if required)

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Mar 14, 2021
@Panquesito7
Copy link
Member Author

I will disable LGTM. About the Mac tests, that should be done in another PR.

@Panquesito7 Panquesito7 merged commit 8f32a02 into master Mar 14, 2021
@Panquesito7 Panquesito7 deleted the replace_codeql_lgtm branch March 14, 2021 19:58
sthagen added a commit to sthagen/TheAlgorithms-C-Plus-Plus that referenced this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants