Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add endlines in hashing/chaining.cpp #1559

Merged
merged 1 commit into from
Aug 15, 2021
Merged

feat: Add endlines in hashing/chaining.cpp #1559

merged 1 commit into from
Aug 15, 2021

Conversation

piyush168713
Copy link
Member

@piyush168713 piyush168713 commented Aug 14, 2021 •
edited by gitpod-io bot

I tried to make some additions in your file, thanks

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@piyush168713
Update chaining.cpp
b0bcaff 
I tried to make some additions in your file, thanks
@Panquesito7 Panquesito7 added the Improvement improvement in previously written codes label Aug 15, 2021
@Panquesito7 Panquesito7 changed the title Update chaining.cpp feat: Add endlines in hashing/chaining.cpp Aug 15, 2021
Panquesito7
Panquesito7 approved these changes Aug 15, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍 🎉

@Panquesito7 Panquesito7 merged commit d088e29 into TheAlgorithms:master Aug 15, 2021
sthagen added a commit to sthagen/TheAlgorithms-C-Plus-Plus that referenced this pull request Aug 16, 2021
@sthagen
Merge pull request #28 from TheAlgorithms/master
6d176c2 
feat: Add endlines in `hashing/chaining.cpp` (TheAlgorithms#1559)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
Improvement improvement in previously written codes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piyush168713 @Panquesito7