Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat. Add SHA-1 hashing algorithm #1609

Merged
merged 10 commits into from Sep 24, 2021

Conversation

tGautot
Copy link
Contributor

@tGautot tGautot commented Sep 19, 2021

Description of Change

Added my own implementation of the SHA-1 Algorithm/Protocol to the hashing directory

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 19, 2021
hashing/sha1.cpp Outdated
// their hash
interactive();
return 0;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing an endline.

@Panquesito7 Panquesito7 added the requested changes changes required label Sep 22, 2021
hashing/sha1.cpp Outdated
Comment on lines 32 to 38
#include <algorithm> // Used for std::copy
#include <array> // Used for std::array
#include <cassert> // Used for assert
#include <cstring> // Used for std::memcopy
#include <iostream> // Used for IO operations
#include <string> // Used for strings
#include <vector> // Used for std::vector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <algorithm> // Used for std::copy
#include <array> // Used for std::array
#include <cassert> // Used for assert
#include <cstring> // Used for std::memcopy
#include <iostream> // Used for IO operations
#include <string> // Used for strings
#include <vector> // Used for std::vector
#include <algorithm> /// for std::copy
#include <array> /// for std::array
#include <cassert> /// for assert
#include <cstring> /// for std::memcopy
#include <iostream> /// for IO operations
#include <string> /// for strings
#include <vector> /// for std::vector

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @tGautot! 🚀 Thank you for your contribution! 😄👍🎉

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes required labels Sep 24, 2021
Copy link
Member

@aminoxix aminoxix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tGautot: Looks good! : )

@Panquesito7 Panquesito7 merged commit 5245b3e into TheAlgorithms:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants