Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changing directory structure to idiomatic go directory format #333

Merged
merged 15 commits into from Sep 7, 2021
Merged

fix: changing directory structure to idiomatic go directory format #333

merged 15 commits into from Sep 7, 2021

Conversation

tjgurwara99
Copy link
Member

@tjgurwara99 tjgurwara99 commented Sep 5, 2021

As the title suggests, I wrote this PR because there are some things within this repo that are not idiomatic to Go style of writing software. I changed the directory structure such that all the underscore characters _ are removed from the package naming as well as changed some code around so that it is more readable and learners can use their own go code to experiment with these structures - main reason why I did a previous restructure #266

Also fixed one of the LGTM analysis alerts which gets this repos alerts to zero.

@lgtm-com
Copy link

lgtm-com bot commented Sep 5, 2021

This pull request fixes 1 alert when merging 38ea851 into 69bca29 - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@raklaptudirm
Copy link
Member

Please re-request a review when this is done.

@lgtm-com
Copy link

lgtm-com bot commented Sep 5, 2021

This pull request fixes 1 alert when merging 3930c92 into f37786a - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2021

This pull request fixes 1 alert when merging df46a1c into f37786a - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@tjgurwara99
Copy link
Member Author

tjgurwara99 commented Sep 6, 2021

NOTE: The action will continue to fail until the PR #338 is merged and I have resolved its conflicts. So I'm waiting for that PR to be merged and will continue with this afterwards.

UPDATE: Done

@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2021

This pull request fixes 1 alert when merging bb4aba1 into e498a69 - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2021

This pull request fixes 1 alert when merging 834f07a into e498a69 - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@tjgurwara99 tjgurwara99 marked this pull request as ready for review September 6, 2021 14:32
@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2021

This pull request fixes 1 alert when merging 5404388 into e498a69 - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

raklaptudirm
raklaptudirm previously approved these changes Sep 6, 2021
siriak
siriak previously approved these changes Sep 7, 2021
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! Could you address my comment asap so that this PR is merged faster and other people can start working with the new structure?

structure/binarytree/binarytree.go Outdated Show resolved Hide resolved
@tjgurwara99 tjgurwara99 dismissed stale reviews from siriak and raklaptudirm via 0803a6b September 7, 2021 09:36
@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2021

This pull request fixes 1 alert when merging 0803a6b into 5ac0bd5 - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2021

This pull request fixes 1 alert when merging 7e5a1b4 into 5ac0bd5 - view on LGTM.com

fixed alerts:

  • 1 for Use of insufficient randomness as the key of a cryptographic algorithm

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@siriak siriak merged commit 59b98b8 into TheAlgorithms:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants