feat(cipher/polybius): add fuzz test to polybius cipher #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcaci
requested review from
siriak,
raklaptudirm,
tjgurwara99 and
yanglbme
as code owners
tjgurwara99
requested changes
Nov 1, 2022
tjgurwara99
approved these changes
Nov 8, 2022
raklaptudirm
approved these changes
Nov 9, 2022
|
I have resolved the conversation after the approvals |
tjgurwara99
approved these changes
Nov 9, 2022
|
@raklaptudirm @siriak I think there is something wrong with my permissions. I'm unable to |
|
@tjgurwara99 Looks like the base branch was out of date so merging was blocked. |
raklaptudirm
pushed a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again, I keep adding fuzz tests for #480, this time for Polybius. I tested it with go test ./cipher/polybius/ to test the corpus and go test -fuzz=FuzzPoly ./cipher/polybius/ to run the fuzzer itself.
If that Is that ok for you to add it let me know. Also if you have any feedbacks about my change let me know so that I can adapt it.
You will see that I did some changes to the errors and restrict some more the possible inputs to the algorithm based a bit on the description of the algorithm in the wikipedia page mentioned at the beginning of the polybius file.
Thanks again for your work!