Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topological Sorting Algorithm Implementation #3060

Merged
merged 20 commits into from Jun 11, 2022
Merged

Topological Sorting Algorithm Implementation #3060

merged 20 commits into from Jun 11, 2022

Conversation

Jtmonument
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Fixes #3059

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Jtmonument
Copy link
Contributor Author

Ignore the force push. I pushed a commit I didn't intend into my master branch which appeared here as well. I rebased it, so now that commit is in a different branch. The commit I intended for this algorithm is up to Add Wikipedia link 2146219.

@Jtmonument
Copy link
Contributor Author

@siriak this implementation is ready to go by the way

anhpham197 and others added 12 commits June 9, 2022 00:50
@anhpham197 @Jtmonument
Add tests for GCD and PrimeCheck (TheAlgorithms#3062)
a235a81
@sanotaku09 @Jtmonument
Add ZigZag Encoding and Longest Nonrepetitive Substring Algorithms (T…
792b27f 
…heAlgorithms#3058)
@RaghavTaneja @siriak @Jtmonument
Add Z-Score Algorithm (TheAlgorithms#3065)
8c45c31 
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
@ntquanghai @Jtmonument
Add tests for findMax (TheAlgorithms#3067)
3799100
@Jtmonument
Completed Topological Sorting Algorithm
f8cfca4
@Jtmonument
Added Junit5 tests for Topological Sorting Algorithm
fa0d686
@Rytnix @Jtmonument
Rename CPUalgorithms to MemoryManagmentAlgorithms (TheAlgorithms#3071)
50a22dd
@Ph1eu @Jtmonument
Add tests for PythagoreanTriple (TheAlgorithms#3070)
d9ada10
@nguyenviettrung-bi11276 @Jtmonument
Add Tests for FindMin (TheAlgorithms#3079)
13378f7
@TaiNguyen2001 @siriak @Jtmonument
Add more tests for findMin (TheAlgorithms#3102)
20a6a31 
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
@huyhq38 @siriak @Jtmonument
Add test for Armstrong (TheAlgorithms#3104)
0ca4a32 
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
@thanhtri122002 @siriak @Jtmonument
Add a test for average (TheAlgorithms#3084)
bee6b6e 
Co-authored-by: thanhtri122002 <thanhnt122002@122002>
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
@Jtmonument Jtmonument force-pushed the master branch 2 times, most recently from 7df76e6 to d9ada10 Compare June 9, 2022 07:15
@Jtmonument Jtmonument marked this pull request as draft June 9, 2022 07:16
@Jtmonument Jtmonument marked this pull request as ready for review June 9, 2022 07:24
@Jtmonument
Copy link
Contributor Author

Not really sure why there is an Update Directory check failure, but I see that you merged other PRs with this same check failure, so I will just ignore it 😆

@Jtmonument Jtmonument requested a review from siriak June 9, 2022 07:27
@Jtmonument Jtmonument requested a review from siriak June 10, 2022 18:58
siriak
siriak approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit 6c4092a into TheAlgorithms:master Jun 11, 2022
Boiarshinov pushed a commit to Boiarshinov/Java that referenced this pull request Jun 20, 2022
@Jtmonument @siriak
@anhpham197 @sanotaku09 @RaghavTaneja @ntquanghai @Rytnix @Ph1eu @nguyenviettrung-bi11276 @TaiNguyen2001 @huyhq38 @thanhtri122002 @Boiarshinov
Add Topological Sorting Algorithm (TheAlgorithms#3060)
6957dc6 
Co-authored-by: thanhtri122002 <thanhnt122002@122002>
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
Co-authored-by: Anh Pham <62592224+anhpham197@users.noreply.github.com>
Co-authored-by: SanOtaku <SanOtaku098@gmail.com>
Co-authored-by: Raghav Taneja <97575679+RaghavTaneja@users.noreply.github.com>
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
Co-authored-by: Hai Nguyen <88832724+ntquanghai@users.noreply.github.com>
Co-authored-by: Utkarsh Yadav <Utkarshrock1510@gmail.com>
Co-authored-by: Phạm Minh Hiếu <84634830+Ph1eu@users.noreply.github.com>
Co-authored-by: nguyenviettrung-bi11276 <101244039+nguyenviettrung-bi11276@users.noreply.github.com>
Co-authored-by: TaiNguyen2001 <102779475+TaiNguyen2001@users.noreply.github.com>
Co-authored-by: de <88503943+HuyQHoang@users.noreply.github.com>
Co-authored-by: thanhtri122002 <93241140+thanhtri122002@users.noreply.github.com>
Co-authored-by: thanhtri122002 <thanhnt122002@122002>
Boiarshinov pushed a commit to Boiarshinov/Java that referenced this pull request Jun 20, 2022
@Jtmonument @siriak
@anhpham197 @sanotaku09 @RaghavTaneja @ntquanghai @Rytnix @Ph1eu @nguyenviettrung-bi11276 @TaiNguyen2001 @huyhq38 @thanhtri122002 @Boiarshinov
Add Topological Sorting Algorithm (TheAlgorithms#3060)
0da0633 
Co-authored-by: thanhtri122002 <thanhnt122002@122002>
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
Co-authored-by: Anh Pham <62592224+anhpham197@users.noreply.github.com>
Co-authored-by: SanOtaku <SanOtaku098@gmail.com>
Co-authored-by: Raghav Taneja <97575679+RaghavTaneja@users.noreply.github.com>
Co-authored-by: Andrii Siriak <siryaka@gmail.com>
Co-authored-by: Hai Nguyen <88832724+ntquanghai@users.noreply.github.com>
Co-authored-by: Utkarsh Yadav <Utkarshrock1510@gmail.com>
Co-authored-by: Phạm Minh Hiếu <84634830+Ph1eu@users.noreply.github.com>
Co-authored-by: nguyenviettrung-bi11276 <101244039+nguyenviettrung-bi11276@users.noreply.github.com>
Co-authored-by: TaiNguyen2001 <102779475+TaiNguyen2001@users.noreply.github.com>
Co-authored-by: de <88503943+HuyQHoang@users.noreply.github.com>
Co-authored-by: thanhtri122002 <93241140+thanhtri122002@users.noreply.github.com>
Co-authored-by: thanhtri122002 <thanhnt122002@122002>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topological Sorting Algorithm