Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable EmptyStatement #5120

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 26, 2024

Related to #5119.

#5121 adds the missing tests for the CircleSort.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 marked this pull request as ready for review April 26, 2024 06:34
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 37.33%. Comparing base (6de154d) to head (6684082).

Files Patch % Lines
.../main/java/com/thealgorithms/sorts/CircleSort.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5120      +/-   ##
============================================
- Coverage     37.35%   37.33%   -0.03%     
+ Complexity     2350     2349       -1     
============================================
  Files           517      517              
  Lines         15623    15622       -1     
  Branches       2971     2971              
============================================
- Hits           5836     5832       -4     
- Misses         9500     9501       +1     
- Partials        287      289       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit de18d0d into TheAlgorithms:master Apr 26, 2024
5 checks passed
@vil02 vil02 deleted the enable_EmptyStatement branch April 27, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants