-
Notifications
You must be signed in to change notification settings - Fork 18.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Sher Lock and Cost Problem. #5169
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5169 +/- ##
============================================
+ Coverage 38.69% 38.74% +0.05%
- Complexity 2384 2387 +3
============================================
Files 517 518 +1
Lines 15405 15417 +12
Branches 2959 2960 +1
============================================
+ Hits 5961 5974 +13
+ Misses 9158 9157 -1
Partials 286 286 ☔ View full report in Codecov by Sentry. |
What are the problems with the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GouthamGuna ,
Firstly fix formatting issues.
If you expand the build you can see -
and +
signed.
It means you have to remove the -
line code and add the +
line code.
Hi @yanglbme, @vil02, @BamaCharanChhandogi Please review the code, and if it meets your approval, proceed to approve it. Otherwise, I would appreciate suggestions for improvement. |
@GouthamGuna the problem looks like a leetcode puzzle and: Line 3 in 2568b96
In my opinion this simply does not fit to this repository. @BamaCharanChhandogi what is your opinion? |
clang-format -i --style=file path/to/your/file.java