Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sher Lock and Cost Problem. #5169

Closed
wants to merge 12 commits into from

Conversation

GouthamGuna
Copy link

@GouthamGuna GouthamGuna commented May 21, 2024

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 38.74%. Comparing base (2568b96) to head (4d5ca6a).

Files Patch % Lines
...algorithms/dynamicprogramming/SherLockAndCost.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5169      +/-   ##
============================================
+ Coverage     38.69%   38.74%   +0.05%     
- Complexity     2384     2387       +3     
============================================
  Files           517      518       +1     
  Lines         15405    15417      +12     
  Branches       2959     2960       +1     
============================================
+ Hits           5961     5974      +13     
+ Misses         9158     9157       -1     
  Partials        286      286              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GouthamGuna
Copy link
Author

GouthamGuna commented May 21, 2024

@BamaCharanChhandogi

What are the problems with the code?

Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GouthamGuna ,
Firstly fix formatting issues.
If you expand the build you can see - and + signed.
It means you have to remove the - line code and add the + line code.

@GouthamGuna
Copy link
Author

GouthamGuna commented May 25, 2024

Hi @yanglbme, @vil02, @BamaCharanChhandogi

Please review the code, and if it meets your approval, proceed to approve it. Otherwise, I would appreciate suggestions for improvement.

@vil02
Copy link
Member

vil02 commented May 30, 2024

@GouthamGuna the problem looks like a leetcode puzzle and:

NOTE: *We DO NOT add leetcode problems. They are just applications of basic principles that can be found in other algorithms included in the repository.*

In my opinion this simply does not fit to this repository.

@BamaCharanChhandogi what is your opinion?

@GouthamGuna GouthamGuna closed this by deleting the head repository Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants