Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: include NM_CLASS_NAMING_CONVENTION and NM_METHOD_NAMING_CONVENTION #5231

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Jun 14, 2024

Continuation of #5122. The necessary code changes were probably done in:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 marked this pull request as ready for review June 14, 2024 15:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.82%. Comparing base (a710fe1) to head (c9847b1).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5231      +/-   ##
============================================
- Coverage     39.82%   39.82%   -0.01%     
+ Complexity     2437     2436       -1     
============================================
  Files           517      517              
  Lines         15476    15476              
  Branches       2958     2958              
============================================
- Hits           6164     6163       -1     
  Misses         9022     9022              
- Partials        290      291       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 enabled auto-merge (squash) June 14, 2024 18:07
@vil02 vil02 force-pushed the include_NM_CLASS_AND_METHOD_NAMING_CONVENTION branch 8 times, most recently from 29a0d23 to c60389b Compare June 21, 2024 19:47
@vil02 vil02 force-pushed the include_NM_CLASS_AND_METHOD_NAMING_CONVENTION branch from c60389b to 058ddbf Compare June 23, 2024 16:50
@vil02 vil02 force-pushed the include_NM_CLASS_AND_METHOD_NAMING_CONVENTION branch from 058ddbf to c9847b1 Compare June 24, 2024 08:53
@vil02 vil02 merged commit d36f54b into TheAlgorithms:master Jun 25, 2024
4 checks passed
@vil02 vil02 deleted the include_NM_CLASS_AND_METHOD_NAMING_CONVENTION branch June 25, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants