Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving BitonicSort #5244

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jun 20, 2024

The previous sorting algorithm only worked with arrays whose sizes were powers of two. This issue has been fixed.

Additionally, the code has been refactored to follow a common approach, and tests for the sort function have been added.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few more remarks, which I will share tomorrow.

src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
@alxkm
Copy link
Contributor Author

alxkm commented Jun 20, 2024

There are issues with the build, not related to any recent code changes. The problem seems to be with the Codecov tool.

src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/test/java/com/thealgorithms/sorts/BitonicSortTest.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/SortUtils.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/SortUtils.java Outdated Show resolved Hide resolved
@vil02
Copy link
Member

vil02 commented Jun 21, 2024

There are issues with the build, not related to any recent code changes. The problem seems to be with the Codecov tool.

Codecov behaves strange for few days.

@alxkm alxkm requested a review from vil02 June 21, 2024 10:10
Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Here are some small remarks to make it perfect.

src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
src/main/java/com/thealgorithms/sorts/BitonicSort.java Outdated Show resolved Hide resolved
@alxkm
Copy link
Contributor Author

alxkm commented Jun 21, 2024

The same for codecov.
"Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1"

@alxkm alxkm requested a review from vil02 June 21, 2024 15:22
@vil02
Copy link
Member

vil02 commented Jun 21, 2024

The same for codecov. "Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1"

It seems to be related to codecov/codecov-action#1487.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@15d2e70). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5244   +/-   ##
=========================================
  Coverage          ?   39.73%           
  Complexity        ?     2435           
=========================================
  Files             ?      517           
  Lines             ?    15515           
  Branches          ?     2958           
=========================================
  Hits              ?     6165           
  Misses            ?     9060           
  Partials          ?      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alxkm alxkm requested a review from vil02 June 21, 2024 18:37
@vil02 vil02 enabled auto-merge (squash) June 21, 2024 19:33
@vil02
Copy link
Member

vil02 commented Jun 21, 2024

I cannot merge it now, because the upload to codecov fails. I will rerun the build in a while, so maybe it will pass.

@vil02 vil02 merged commit 8ef69bc into TheAlgorithms:master Jun 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants