Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new issue template #1206

Merged
merged 12 commits into from
Nov 6, 2022
Merged

Adding new issue template #1206

merged 12 commits into from
Nov 6, 2022

Conversation

zendranm
Copy link
Contributor

@zendranm zendranm commented Oct 18, 2022 •
edited
Loading

Open in Gitpod know more

Solves issue #1204

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@zendranm zendranm marked this pull request as ready for review October 18, 2022 15:17
@zendranm zendranm mentioned this pull request Oct 18, 2022
Closed
appgurueu
appgurueu reviewed Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature request template is not really applicable; algorithms are not to be requested (rather, PRs should be opened directly). The bug template should probably have a "bug" label. Hints to the one opening the issue such as "Before you open an issue ..." should be comments.

@Panquesito7
Copy link
Member

The feature request template is not really applicable...

I still think we should keep the feature request template. For example: what if I want to add a new workflow or functionality and make an issue before making any PRs?
@raklaptudirm, what do you think about this?

@Panquesito7 Panquesito7 added the documentation PR that adds or fixes docs; issue that points out issues with the docs label Oct 18, 2022
@Panquesito7 Panquesito7 linked an issue Oct 18, 2022 that may be closed by this pull request
[DOCS] Add issue templates #1204
Closed
@raklaptudirm
Copy link
Member

The feature request template is not really applicable...

I still think we should keep the feature request template. For example: what if I want to add a new workflow or functionality and make an issue before making any PRs?

@raklaptudirm, what do you think about this?

We should explicitly mention in the issue template that it is not for requesting algorithms imo.

@zendranm zendranm requested review from Panquesito7 and appgurueu and removed request for appgurueu and Panquesito7 October 21, 2022 11:23
Panquesito7
Panquesito7 reviewed Oct 26, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yml Show resolved Hide resolved
Panquesito7
Panquesito7 requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong indentation.

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
Panquesito7
Panquesito7 previously approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! 🚀

@zendranm
Copy link
Contributor Author

zendranm commented Oct 28, 2022 •
edited
Loading

@Panquesito7 @appgurueu Since there is not much time until the end of the Hactoberfest, would you mind adding the hacktoberfest-accepted label to this PR? I will add any required code-review changes once I get a response here.

@appgurueu appgurueu added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 28, 2022
@zendranm zendranm requested review from Panquesito7 and appgurueu and removed request for appgurueu and Panquesito7 November 6, 2022 14:16
Panquesito7
Panquesito7 approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! 🚀

@Panquesito7 Panquesito7 merged commit 9d4adbb into TheAlgorithms:master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Assignees
No one assigned
Labels
documentation PR that adds or fixes docs; issue that points out issues with the docs hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] Add issue templates
4 participants
@zendranm @Panquesito7 @raklaptudirm @appgurueu