Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BogoSort.js: Simplify Array.isSorted() and add doctests #171

Merged
merged 18 commits into from
May 13, 2020

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented May 12, 2020

As discussed at #164 (comment)

Also related to add doctests as discussed in #142

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

As discussed at #164 (comment)

Also related to add doctests as discussed in #142
@cclauss cclauss requested review from itsvinayak and poyea May 12, 2020 20:22
@cclauss
Copy link
Member Author

cclauss commented May 12, 2020

The one downside with running doctests is that code at global scope is executed. This is the same in Python so in that repo we suggest indenting global code under if __name__ == "__main__":. Is there a similar JavaScript construct that we could recommend in this repo for use with doctests?

running doctests in Sorts/BogoSort.js...
[
  5, 6,  7,  8,
  1, 2, 12, 14
]
[
  1, 2,  5,  6,
  7, 8, 12, 14
]
....

@itsvinayak
Copy link
Member

@cclauss, great work sir

@cclauss cclauss mentioned this pull request May 13, 2020
12 tasks
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poyea poyea merged commit 8fca284 into master May 13, 2020
@poyea poyea deleted the Simplify-Array.isSorted branch May 13, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants