Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor changes in docstring (knapsack_dp) #11409

Closed
wants to merge 2 commits into from

Conversation

Aterolite24
Copy link

@Aterolite24 Aterolite24 commented May 21, 2024

Describe your change:

Added changes to docstrings from 11406

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • [ ✔️ ] Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • [✔️ ] I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • [✔️ ] I know that pull requests will not be merged if they fail the automated tests.
  • [✔️ ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ ✔️ ] All new Python files are placed inside an existing directory.
  • [ ✔️ ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ ✔️ ] All functions and variable names follow Python naming conventions.
  • [ ✔️ ] All function parameters and return values are annotated with Python type hints.
  • [ ✔️ ] All functions have doctests that pass the automated testing.
  • [ ✔️ ] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • [ ✔️ ] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels May 21, 2024
@Aterolite24 Aterolite24 changed the title minor changes in docstring minor changes in docstring (knapsack_dp) May 21, 2024
@Aterolite24 Aterolite24 reopened this May 21, 2024
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Author

@Aterolite24 Aterolite24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks have been passed. If any changes are required, please let me know.

Thanks :)

@Aterolite24 Aterolite24 requested a review from imSanko May 24, 2024 05:48
@tianyizheng02
Copy link
Contributor

I'm closing this issue because we actually already have an implementation of this algorithm in dynamic_programming/knapsack.py. The author of #11406 didn't do the due diligence of checking the repo beforehand, so by extension your PR is unfortunately a duplicate as well. However, we'd very much welcome a PR that improves upon our existing implementation.

@Aterolite24
Copy link
Author

Okay .. sure ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants