Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add First Quantum Qiskit Code Tutorial #3173

Merged
merged 8 commits into from
Oct 12, 2020
Merged

Add First Quantum Qiskit Code Tutorial #3173

merged 8 commits into from
Oct 12, 2020

Conversation

abhishekjiitr
Copy link
Contributor

@abhishekjiitr abhishekjiitr commented Oct 10, 2020 •
edited
Loading

Describe your change:

Add First Quantum Qiskit Code Tutorial
Fixes #2923

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@abhishekjiitr abhishekjiitr mentioned this pull request Oct 10, 2020
Closed
@TravisBuddy
Copy link

Travis tests have failed

Hey @abhishekjiitr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0b0f1550-0b4c-11eb-9624-fb6a3f266bd5

cclauss
cclauss requested changes Oct 11, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. As discussed in CONTRIBUTING.md, algorithms should be Python functions or classes with type hints and doc tests.

quantum/q1.py Outdated Show resolved Hide resolved
@abhishekjiitr
Copy link
Contributor Author

@cclauss added new commit with requested changes

@cclauss cclauss merged commit 6e01004 into TheAlgorithms:master Oct 12, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@abhishekjiitr @cclauss @stokhos
Add First Quantum Qiskit Code Tutorial (TheAlgorithms#3173)
eaf3e9f 
* Add First Quantum Qiskit Code Tutorial

* Add Qiskit Requirement

* Address Review Comments

* fixup! Format Python code with psf/black push

* Update q1.py

* updating DIRECTORY.md

* Update and rename q1.py to single_qubit_measure.py

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@abhishekjiitr @cclauss
Add First Quantum Qiskit Code Tutorial (TheAlgorithms#3173)
12f416c 
* Add First Quantum Qiskit Code Tutorial

* Add Qiskit Requirement

* Address Review Comments

* fixup! Format Python code with psf/black push

* Update q1.py

* updating DIRECTORY.md

* Update and rename q1.py to single_qubit_measure.py

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Hacktoberfest] Need some quantum algorithms!
3 participants
@abhishekjiitr @TravisBuddy @cclauss