Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digital root method #6140

Closed
wants to merge 38 commits into from
Closed

digital root method #6140

wants to merge 38 commits into from

Conversation

meg-1
Copy link
Contributor

@meg-1 meg-1 commented May 11, 2022 •
edited

Describe your change:

added the 'digital_root' method to maths/sum_of_digits.py.
a digital root is: https://en.wikipedia.org/wiki/Digital_root

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

meg-1 and others added 26 commits May 16, 2021 13:18
@meg-1
Added censor function
00c22a3
@meg-1
Added censor code
4194344
@meg-1
Added comments to the code
e7d4102
@meg-1
modified censor function
93bd4ac
@meg-1
added decrypt function
b714278
@meg-1
added cypher and decypher functions, deleted censor and decrypt funct…
c879c7f 
…ions
@meg-1
Deleted decrypt.py
e60dd6f
@meg-1
Deleted censor.py
b3e0cb8
@meg-1
Merge branch 'TheAlgorithms:master' into master
e14b9ef
@meg-1
edited the crypt and decrypt files
947f7d8
@meg-1
Update cypher_txt.py
daf21ad
@meg-1
Remove the endline in cypher.py
d3d8b29
@meg-1
Removed the print at the end of decypher.py
752c197
@meg-1
comitting changes
9f44028
@meg-1
added 4 new algorithms
f72431b
@meg-1
added tests to the four files
4c891f4
@meg-1
added type hints for the function variables
c600b10
@meg-1
Merge branch 'TheAlgorithms:master' into master
4286e40
@meg-1
Deleted decode message
7a909e2
@meg-1
Deleted code message
f5b5411
@meg-1
Welford average algorithm
bc8388c
@meg-1
added average welford algorithm
9be479e
@meg-1
indentation added
5ebf785
@meg-1
switched print to return in the end
0570692
@meg-1
added digital_root function
b589177
@meg-1
re-opened the digital root pr
16f087f
@meg-1 meg-1 requested a review from Kush1101 as a code owner May 11, 2022 14:07
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 11, 2022
@ghost ghost added the tests are failing Do not merge until tests pass label May 12, 2022
@meg-1
fixed mistakes sum_of_digits
669a12c 
fixed syntax, readibility, indentation
@meg-1
Copy link
Contributor Author

meg-1 commented Jun 1, 2022

@poyea , sorry to disturb, the pre-commits in my pull requests keep failing although everything seems alright with the code. the workflow keeps telling me to add blank lines, but it never lets the checks go through even when i add them. could you please reccomend something to fix this issue?

@meg-1
fixed "sum_of_digits.py"
b49257b 
fixed pre-commit issues
@poyea
Copy link
Member

poyea commented Jun 2, 2022

FAILED arithmetic_analysis/in_static_equilibrium.py::arithmetic_analysis.in_static_equilibrium.polar_force can be ignored. See #6170

poyea and others added 2 commits June 11, 2022 20:50
@poyea
fix black
8c4653c
@meg-1
fixing Value Error
4e09780 
fixed the Value Error [ 73d line ]
@meg-1
Copy link
Contributor Author

meg-1 commented Jun 18, 2022

@Kush1101 could you please check out this pull request?

@meg-1
adding tests to digital_root
fbec04e 
added an exception for an invalid input, as well as tests regarding it.
@meg-1
Copy link
Contributor Author

meg-1 commented Jul 2, 2022

@Kush1101 could you please check out this pull request?

poyea
poyea reviewed Jul 3, 2022
View reviewed changes
maths/sum_of_digits.py Outdated Show resolved Hide resolved
@poyea poyea self-assigned this Jul 3, 2022
meg-1 and others added 3 commits July 9, 2022 14:01
@meg-1 @poyea
Update maths/sum_of_digits.py
901c4fa 
comitting the suggestion.

Co-authored-by: John Law <johnlaw.po@gmail.com>
@meg-1
fixing return type
c56f3f1 
implementing bot reccomendations [ fixing the TypeError return in digital_root ]
@meg-1
fixing tests in digital_root
bd8dd3f 
updating tests
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 9, 2022
cclauss
cclauss reviewed Jul 11, 2022
View reviewed changes
maths/sum_of_digits.py Outdated Show resolved Hide resolved
@meg-1 @cclauss
enhancing maths/sum_of_digits.py
67eca3a 
Co-authored-by: Christian Clauss <cclauss@me.com>
@ghost ghost added the tests are failing Do not merge until tests pass label Jul 13, 2022
@meg-1
Copy link
Contributor Author

meg-1 commented Aug 3, 2022

@poyea , hi! i would like to ask if the error shown after running my file in this commit is on my side, or on the repository's??
image
here's an attatched screen.

@cclauss
Copy link
Member

cclauss commented Aug 3, 2022

Please rebase this pull request.

@meg-1 meg-1 closed this Aug 13, 2022
@meg-1 meg-1 deleted the sum_of_digits branch August 13, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@poyea poyea poyea left review comments

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

@poyea poyea

Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meg-1 @poyea @cclauss