Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multi-Level-Feedback-Queue scheduling algorithm #6165

Merged
merged 7 commits into from
Jun 4, 2022
Merged

Add Multi-Level-Feedback-Queue scheduling algorithm #6165

merged 7 commits into from
Jun 4, 2022

Conversation

devycha
Copy link
Contributor

@devycha devycha commented May 24, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels May 24, 2022
@devycha devycha mentioned this pull request May 27, 2022
Closed
@ghost ghost removed the tests are failing Do not merge until tests pass label May 31, 2022
@poyea poyea self-assigned this May 31, 2022
poyea
poyea approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩 Looks good to me in general!!

scheduling/multi_level_feedback_queue.py Outdated
Comment on lines 5 to 7
"""
Process should have these fields below
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok to remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestions!😃😃
I'm sorry for bothering you cause my English skill is not good.

scheduling/multi_level_feedback_queue.py Outdated Show resolved Hide resolved
scheduling/multi_level_feedback_queue.py Outdated Show resolved Hide resolved
scheduling/multi_level_feedback_queue.py Outdated Show resolved Hide resolved
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 31, 2022
@poyea poyea added the awaiting merge This PR is approved and ready to be merged label May 31, 2022
devycha and others added 2 commits June 2, 2022 13:40
@devycha @poyea
Update scheduling/multi_level_feedback_queue.py
2e8d989 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@devycha @poyea
Update scheduling/multi_level_feedback_queue.py
0a9b3b3 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting merge This PR is approved and ready to be merged labels Jun 2, 2022
@devycha
Copy link
Contributor Author

devycha commented Jun 2, 2022

I'm sorry. awaiting merge label is removed because of my new commit.
I don't know if this is right.🥲

@ghost ghost added the tests are failing Do not merge until tests pass label Jun 4, 2022
@devycha @poyea
Update scheduling/multi_level_feedback_queue.py
210e395 
Co-authored-by: John Law <johnlaw.po@gmail.com>
poyea
poyea approved these changes Jun 4, 2022
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 4, 2022
@poyea poyea merged commit a44afc9 into TheAlgorithms:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

Assignees

@poyea poyea

Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@devycha @poyea