Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added algorithm for Group Anagram #6528

Closed
wants to merge 13 commits into from

Conversation

shreyasharma6602
Copy link

@shreyasharma6602 shreyasharma6602 commented Oct 2, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains

Fixes: #6527 .

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names labels Oct 2, 2022
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

strings/group_anagrams.py Outdated Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot removed the require descriptive names This PR needs descriptive function and/or variable names label Oct 2, 2022
@yashgosa
Copy link

yashgosa commented Oct 2, 2022

hey @shreyasharma6602 I am facing the issue of requires doctest can you please help me out ? what is doctest?

@shreyasharma6602
Copy link
Author

hey @shreyasharma6602 I am facing the issue of requires doctest can you please help me out ? what is doctest?

Doctest is a module which is used for better testing purpose. You can try to implement it from these links.
Doctest
Doctest Python Documentation

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 2, 2022
@yashgosa
Copy link

yashgosa commented Oct 2, 2022

thanks @shreyasharma6602

@cclauss
Copy link
Member

cclauss commented Oct 2, 2022

What a terrible title for a pull request. The title should explain what the PR does and the issue number should be in the commit message so the reader can click on it.

@shreyasharma6602 shreyasharma6602 changed the title Resolve issue number #6527 Added algorithm for Group Anagram Oct 2, 2022
strings/group_anagrams.py Outdated Show resolved Hide resolved
strings/group_anagrams.py Outdated Show resolved Hide resolved
strings/group_anagrams.py Outdated Show resolved Hide resolved
strings/group_anagrams.py Outdated Show resolved Hide resolved
@cclauss
Copy link
Member

cclauss commented Oct 16, 2022

Please read CONTRIBUTING.md.

Hacktoberfest is strenuous for our team of active volunteer maintainers. That small team now has 200+ open pull requests to review. We have high standards for our submissions which are described in CONTRIBUTING.md. Our continuous integration tests help to ensure that our standards are met before we review and merge deserving pull requests. This is further complicated by the fact that we already have lots of algorithms and would like to avoid duplicates.

For these reasons, I will close all open pull requests failing tests so that our unpaid team has a smaller mountain to climb. If you want us to land your pull request, please read CONTRIBUTING.md carefully and try again.

@cclauss cclauss closed this Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Anagrams | String
3 participants