Project Euler problem148

[saitejamanchi]

Describe your change:

Added solution for Problem 148 in Project Euler.

• Add an algorithm?
• Fix a bug or typo in an existing algorithm?
• Documentation change?

Checklist:

• I have read CONTRIBUTING.md.
• This pull request is all my own work -- I have not plagiarized.
• I know that pull requests will not be merged if they fail the automated tests.
• This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
• All new Python files are placed inside an existing directory.
• All filenames are in all lowercase characters with no spaces or dashes.
• All functions and variable names follow Python naming conventions.
• All function parameters and return values are annotated with Python type hints.
• All functions have doctests that pass the automated testing.
• All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
• If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

[rohan472000]

It has a hardcoded value of pascal_row_count which is only 10^4. As a result, the function returns the result for the first 10^4 rows of Pascal's triangle instead of the first billion rows, try this:

def solution(pascal_row_count: int = 10**9) -> int:

[saitejamanchi]

Hey,

I've tried with 10**9 but one of the tests failed due to timeout as it was taking more than 6 hours to run.

[rohan472000]

It's not uncommon for brute force solutions to take a long time or run into timeout issues when dealing with very large inputs. In this case, the input value of 10**9 is extremely large, and the current implementation of the "solution" function does not have an efficient algorithm to handle such large inputs.

[rohan472000]

use below codes for better efficiency which will solve the timeout issue:-

  def solution(pascal_row_count: int = 10**9) -> int:
      """
      To evaluate the solution, use solution()
      >>> solution(3)
      6
      >>> solution(10)
      40
      >>> solution(100)
      2361
      """
  
      # Helper function to compute the number of odd binomial coefficients in a row
      def odd_binomials(n: int) -> int:
          res = 0
          while n > 0:
              res += n % 2
              n //= 2
          return res
  
      # Compute the sum of odd binomial coefficients modulo 7 for each row up to pascal_row_count
      result = 0
      for k in range(pascal_row_count):
          result += odd_binomials(k) % 7
  
      return result

[rohan472000]

also add docs in odd_binomials, you can put above comment of that function inside as a doc.

[rohan472000]

use ruff . then ruff . --fix to fix ruff issues.

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[algorithms-keeper]

As there is no test file in this pull request nor any test function or class in the file project_euler/problem_148/sol1.py, please provide doctest for the function get_num_binomials

[rohan472000]

@saitejamanchi add doctests.

[saitejamanchi]

@rohan472000 Sure, will add.

Thanks a lot for the help!!

[algorithms-keeper]

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

• Contributing guidelines
• Project Euler solution guidelines

Python:

• Formatted string literals (f-strings)
• Type hints
• doctest
• unittest
• pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

---

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

• @algorithms-keeper review to trigger the checks for only added pull request files
• @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

[algorithms-keeper]

As there is no test file in this pull request nor any test function or class in the file project_euler/problem_148/sol1.py, please provide doctest for the function get_num_binomials

[rohan472000]

kindly fix ruff issue before committing...by ruff . then ruff . --fix

[saitejamanchi]

Hi @dhruvmanila ,

Could you please look into this pull request?