-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Monte Carlo simulation, Markowitz portfolio optimization and Kalman filter #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove spaces from file paths? That's the way files are usually named here. And maybe move it to quantitative_finance
directory? I'm waiting for #121 to be merged, and then I'll merge this one.
Sure, I will do it |
Done, please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also write file names in snake_case
? The code looks good, but, as I said, I need #121 to be merged first, so this PR will have to wait for a little while.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Ref-Adding Quantitative finance algorithms Adding Quantitative finance algorithms #122