chore: use workflow from the scripts repository
#209
Conversation
There was a problem hiding this comment.
@Panquesito7 Thank you!
I've confirmed that the action is working fine already in TheAlgorithms/C-Plus-Plus, and also confirmed that python build_directory_md.py Ruby . .rb generates a valid DIRECTORY.md.
I think it's almost fine, but I think there is a need to fix on.push.branches. Can you please check the comment?
Co-authored-by: vzvu3k6k <vzvu3k6k@gmail.com>
…workflow" This reverts commit 275bed9, reversing changes made to 14149d1. This action failed for some reason. https://github.com/TheAlgorithms/Ruby/actions/runs/5337370931/jobs/9673337632 I'll revert this merge commit teporarily until it is fixed.
…workflow" This reverts commit 275bed9, reversing changes made to 14149d1. This action failed for some reason. https://github.com/TheAlgorithms/Ruby/actions/runs/5337370931/jobs/9673337632 I'll revert this merge commit temporarily until it is fixed.
Temporarily revert new update_directory_md workflow (#209)
|
@Panquesito7 It seems I missed something during the review... The action failed after the merge (log). So this PR has been temporarily reverted by #211. I would appreciate it if you could submit a pull request with the bug fixed. I will investigate when I have time as well. (By the way, I checked the TheAlgorithms/C-Plus-Plus repository again, and it appears that this action is not actually executed, because the branch name of the action |
|
Thanks for spotting that out! Weird that happened 👀 I believe the issue should be made in the scripts repository. |
|
@Panquesito7 Thanks for the confirmation! I have reported it in TheAlgorithms/scripts#27. For the TheAlgorithms/C-Plus-Plus, I'm not sure whether to report the issue in an existing issue or create a new one. I'll leave the decision up to you. Anyway I think this workflow would be very useful if it works. Thank you for trying to develop it 👍 |
| with: | ||
| fetch-depth: 0 | ||
| - name: Build directory | ||
| uses: TheAlgorithms/scripts/directory_md@main |
There was a problem hiding this comment.
Hey 👋🏼 could one of you create a branch which uses the patch I made in this PR.
Just change the above line to something like this and it should hopefully work - if it doesn't, ping me directly please and I can take a look at the action log
| uses: TheAlgorithms/scripts/directory_md@main | |
| uses: TheAlgorithms/scripts/directory_md@e24e3ba9cf7e90c91ac87f953593426328b86563 |
If it works then I can merge my fix and then you won't have to merge this suggested change.
Things added/changed:
scriptsrepository.