Properly evaluate GITHUB_ACTOR
#647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 283 283
Lines 22801 22801
=======================================
Hits 21566 21566
Misses 1235 1235 ☔ View full report in Codecov by Sentry. |
vil02
force-pushed
the
proper_evaluate_GITHUB_ACTOR
branch
from
a517d25
to
12ecf53
Compare
vil02
changed the title
GITHUB_ACTORGITHUB_ACTOR
|
About the name, let's set it to "Github Actor". Looks reasonable. Could you do that here? |
vil02
force-pushed
the
proper_evaluate_GITHUB_ACTOR
branch
from
31a46a3
to
7c14b96
Compare
siriak
approved these changes
Jan 8, 2024
This was referenced Jan 9, 2024
This was referenced Jan 16, 2024
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
git logcontains records like:This PR properly evaluates the
GITHUB_ACTORvariable in the respective workflow. When this will be merged, I will create similar PR in other repos.Something to consider
Since
user.emailis generated usingGITHUB_ACTOR, should alsouser.namebe set toGITHUB_ACTOR?Type of change
Please delete options that are not relevant.
Checklist:
COUNTRIBUTING.mdand my code follows its guidelines.