Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codecov/codecov-action to v4 #670

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Feb 1, 2024

Description

Toneless uploads to codecov are no longer supported. This PR updates codecov/codecov-action to v4 and changes the upload workflow in such a way that:

  • tokenless upload it used for PRs created from forks,
  • upload with token is used for every other occasion.

Before merge: please make sure to add the token as CODECOV_TOKEN into the repo secrets. (Token was added)

It seems that both of the branches work:

  • tokenless,
  • without token - the job has failed due to the lack of the token in my fork, but the branch was correctly selected.

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17d5dad) 94.68% compared to head (1ba8b44) 94.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files         292      292           
  Lines       23258    23258           
=======================================
  Hits        22022    22022           
  Misses       1236     1236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siriak siriak self-requested a review February 2, 2024 06:36
@vil02 vil02 force-pushed the update_codecov_action_to_v4 branch from ceba78a to 1ba8b44 Compare February 2, 2024 08:15
@vil02
Copy link
Member Author

vil02 commented Feb 2, 2024

@siriak: I think you can merge it. My strong conjecture is that the push will go through the upload with token branch.

@vil02 vil02 marked this pull request as ready for review February 2, 2024 08:23
@vil02 vil02 requested a review from imp2002 as a code owner February 2, 2024 08:23
@vil02 vil02 requested a review from siriak February 2, 2024 08:24
@siriak siriak merged commit 5fa2cf4 into TheAlgorithms:master Feb 2, 2024
4 checks passed
@vil02
Copy link
Member Author

vil02 commented Feb 2, 2024

@siriak thanks! I just checked, everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants