Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve website style on Arabic #285

Merged

Conversation

ahmed0saber
Copy link
Contributor

Closes #251

What change does this pull request introduce?
Improving the style of TheAlgorithms website on Arabic, by adjusting the direction to "rtl", replacing left and right of margin and padding to inline-start and inline-end, forcing "ltr" direction in some places, and finally adding some custom styling if required.

Screenshots
screencapture-3000-thealgorithms-website-q2fhlgkhxd5-ws-eu110-gitpod-io-ar-2024-04-28-21_47_43

Checklist

  • I worked on a branch other than main.
  • My branch is up-to-date with the Upstream main branch.
  • I have fixed potential errors using yarn lint.
  • I ran yarn build to check everything still builds successfully.

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 9:31am

Copy link
Collaborator

@maltejur maltejur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems like a great change. One small thing.

styles/globals.css Outdated Show resolved Hide resolved
@ahmed0saber
Copy link
Contributor Author

Hello @maltejur , hope you are doing well.
I have moved the global styles of Arabic and RTL into respective CSS modules, and fixed a small issue I have found with the translate icon in side menu of navbar.

Copy link
Collaborator

@maltejur maltejur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks!

@maltejur maltejur merged commit e7be8a9 into TheAlgorithms:main May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Paragraphs and headlines not aligned correctly in Arabic version
2 participants