Change margin-left & margin-right properties to fix a bug with RTL languages
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `margin-left` and `margin-right` properties of the links and the icon inside title container in language page with `margin-inline-start` and `margin-inline-end` because when the `direction` property of these elements changed to "rtl", `margin-inline-start` and `margin-inline-end` change margins directions of the elements to suit the "rtl" direction.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
My pleasure, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286
What change does this pull request introduce?
Replaces the properties
margin-leftandmargin-rightof the icon and the buttons links inside title containersection in language page with
margin-inline-startandmargin-inline-end, because whendirectionpropertyof the icon and buttons links changed to "rtl",
margin-inline-startandmargin-inline-endchange marginsdirections of the icon and buttons links to suit the "rtl" direction, Unlike
margin-leftandmargin-rightthat keep the margins in one direction even if the direction of the icon and buttons links changed.
Screenshots
before changes:
After changes:
Checklist
main.yarn lint.mainbranch.yarn buildto check everything still builds successfully.