Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix too long algorithm name wrapping on card #98

Merged
merged 1 commit into from Jun 13, 2021
Merged

Fix too long algorithm name wrapping on card #98

merged 1 commit into from Jun 13, 2021

Conversation

maltejur
Copy link
Collaborator

Closes #97

What change does this pull request introduce?
Hides too long algorithm name and adds a tooltip instead of wrapping it.

Screenshots
Before:
1

After:
2
3

Checklist

  • I worked on a branch other than main.
  • My branch is up-to-date with the Upstream main branch.
  • I have fixed potential errors using yarn lint.
  • I ran yarn build to check everything still builds successfully.

@maltejur maltejur added the bug Something isn't working label Jun 12, 2021
@vercel
Copy link

vercel bot commented Jun 12, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thealgorithms/website/4KMWSJR2hYi6QxAqDTUXiPa4PQE6
✅ Preview: https://website-git-fixtoolongname-thealgorithms.vercel.app

Panquesito7
Panquesito7 approved these changes Jun 13, 2021
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@github-actions github-actions bot added the approved Approved; waiting for merge label Jun 13, 2021
@Panquesito7 Panquesito7 merged commit 11bcbe5 into main Jun 13, 2021
@Panquesito7 Panquesito7 deleted the fix_too_long_name branch June 13, 2021 00:17
Panquesito7 added a commit that referenced this pull request Jun 14, 2021
@Panquesito7
Fix dark mode for #98 PR
01d37a0
@Panquesito7 Panquesito7 mentioned this pull request Jun 14, 2021
Closed
Panquesito7 added a commit that referenced this pull request Jun 14, 2021
@Panquesito7
Fix a bug in dark mode introduced by #98
cfe2d31
Panquesito7 added a commit that referenced this pull request Jun 14, 2021
@Panquesito7
Fix a bug in dark mode introduced in #98
5f2c4bc
@Panquesito7 Panquesito7 mentioned this pull request Jun 14, 2021
Merged
4 tasks
maltejur pushed a commit that referenced this pull request Jun 15, 2021
@Panquesito7
Fix a bug in dark mode introduced in #98 (#100)
d9b4a7f 
* Fix a bug in dark mode introduced in #98

* Remove all the other elements except the...

...background property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
approved Approved; waiting for merge bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uneven sized algorithm box components on algorithm category pages
2 participants
@maltejur @Panquesito7