Introduced render notification cb for average and max timing reports #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| UInt32 inNumberFrames, | ||
| AudioBufferList * __nullable ioData) | ||
| { | ||
| static UInt64 startTime = 0; |
There was a problem hiding this comment.
There can be multiple IO units in the same process, so these variables should rather be instance variables.
There was a problem hiding this comment.
Yes, that's how Michael had it initially, but eventually I decided statics, because it is easier to copy-paste the code. Having said that, for public code, it probably is better to encapsulate it in an object or struct, but I prefer it not to be part of the actual module.
|
Implemented in SHA 9b83661 with some modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.