Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Microsoft.IO.RecyclableStreams to v3 #10

Merged

Conversation

ntwilson
Copy link
Contributor

@ntwilson ntwilson commented Mar 2, 2024

Types of changes

What types of changes does your code introduce to FSharp.Control.WebSockets?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

Fixes #9. There were no code changes, it just needed to be recompiled with the new package version. The failure was due to them changing the return type of a method from MemoryStream to RecyclableMemoryStream, so the method wasn't found at runtime, but that didn't need anything to change in the code.

Paket added a bunch of other unrelated changes. At work, we typically just ignore those other changes. Would you prefer they were reverted?

Copy link
Owner

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Changes look fine. I’ll merge and release when I’m near my computer next.

@TheAngryByrd TheAngryByrd merged commit 5e58fa0 into TheAngryByrd:master Mar 4, 2024
3 checks passed
TheAngryByrd added a commit that referenced this pull request Mar 4, 2024
## [0.3.0-beta001] - 2024-03-04

### Changed

- [Update Microsoft.IO.RecyclableStreams to v3](#10) thanks @ntwilson
TheAngryByrd added a commit that referenced this pull request Mar 4, 2024
## [0.3.0] - 2024-03-04

### Changed
- [Update Microsoft.IO.RecyclableStreams to v3](#10) thanks @ntwilson
@ntwilson ntwilson deleted the update-recyclable-streams branch March 4, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.IO.RecyclableMemoryStream 3.0.0 Crashes
2 participants