Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #197 #198

Merged
merged 1 commit into from Mar 8, 2020
Merged

Fixes #197 #198

merged 1 commit into from Mar 8, 2020

Conversation

TheAngryByrd
Copy link
Owner

@TheAngryByrd TheAngryByrd commented Mar 8, 2020

microsoft made a breaking change by renaming their CSharp plugin. See: https://twitter.com/devlead/status/1236284450645979136

Proposed Changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

microsoft made a breaking change by renaming their CSharp plugin. See: https://twitter.com/devlead/status/1236284450645979136
@TheAngryByrd TheAngryByrd merged commit 72c646c into master Mar 8, 2020
@TheAngryByrd TheAngryByrd deleted the 197-fix-microsoft-extension branch March 8, 2020 15:27
TheAngryByrd pushed a commit that referenced this pull request Mar 8, 2020
## [0.23.4] - 2020-03-08

### Fixed
- Fixed issues of opening the browser with the docs generation tool from [@TheAngryByrd](https://github.com/TheAngryByrd) - (#195)
- Fixed staging too many files during Release mode from [@ominestre](https://github.com/ominestre) - (#196)
- Fixed an issue with extension recommendations. Microsoft changed their CSharp tooling identifier from [@TheAngryByrd](https://github.com/TheAngryByrd) - (#198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant