Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #273 #274

Merged
merged 2 commits into from Sep 5, 2023
Merged

Fix #273 #274

merged 2 commits into from Sep 5, 2023

Conversation

nikoyak
Copy link
Contributor

@nikoyak nikoyak commented Sep 2, 2023

Proposed Changes

Fix #273

Types of changes

What types of changes does your code introduce to MiniScaffold?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

TheAngryByrd
TheAngryByrd requested changes Sep 2, 2023
View reviewed changes
Copy link
Owner

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left some comments.

Content/Library/src/MyLib.1/MyLib.1.fsproj Outdated Show resolved Hide resolved
Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj Outdated Show resolved Hide resolved
@nikoyak
Tuned AssemblyInfo's related things
e68a139 
- Disabled msbuild's AssemblyInfo.fs generation everywhere
- AssemblyInfo.fs generation with Fake is left only at the /src level of application and library templates
TheAngryByrd
TheAngryByrd approved these changes Sep 5, 2023
View reviewed changes
Copy link
Owner

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 Thanks!!!

@TheAngryByrd TheAngryByrd merged commit 8011367 into TheAngryByrd:master Sep 5, 2023
3 checks passed
TheAngryByrd added a commit that referenced this pull request Sep 5, 2023
@TheAngryByrd
Bump version to 0.34.1
8d2be79 
## [0.34.1] - 2023-09-05

### Changed
- [Fixes AssemblyInfo generation](#274)  from @nikoyak
@nikoyak nikoyak deleted the fix-assemblyinfo-ignoring branch February 5, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssemblyInfo.fs are ignored
2 participants
@nikoyak @TheAngryByrd