Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide items at the end of swiper if it's not looping #59

Merged

Conversation

SamadiPour
Copy link

In the STACK layout with the right direction, when it's a non-looping swiper, it still shows some items which indicate that the user can swipe, but in reality, it's the end of the swiper, and the user can't swipe.
This can be worst when there are only one or two pictures in swiper.

fixes: #55

OLD - one picture non-looping:
image

NEW - one picture non-looping:
image

OLD - two pictures non-looping:
image

NEW - two pictures non-looping:
image

@TheAnkurPanchani TheAnkurPanchani merged commit b73dd0a into TheAnkurPanchani:master Nov 15, 2022
@SamadiPour SamadiPour deleted the stack-ui-improvement branch February 7, 2023 12:48
@Dabbit-Chan
Copy link

Dabbit-Chan commented Jun 26, 2023

This code does not seem to work fully. I added if (!widget.loop && itemIndex < 0) continue; into the loop to make it work.
image
@TheAnkurPanchani @SamadiPour

@lucianokapluk
Copy link

Hi, any update for this?

@TheAnkurPanchani
Copy link
Owner

v3 is released with this fix.

@lucianokapluk
Copy link

Thank you! It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In SwiperLayout.STACK mode, card always shows even if it has only one card
4 participants