Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more of InGameUI #1064

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Jan 29, 2024

No description provided.

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch.

InGameUI::Create_Mouseover_Hint
InGameUI::Update

left to look at

src/game/logic/object/update/aiupdate.h Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Show resolved Hide resolved
src/game/client/ingameui.cpp Show resolved Hide resolved
src/game/client/ingameui.cpp Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 717 lines in your changes are missing coverage. Please review.

Comparison is base (0524e8b) 2.63% compared to head (40bcc6f) 2.61%.

Files Patch % Lines
src/game/client/ingameui.cpp 0.00% 710 Missing ⚠️
src/game/client/globallanguage.h 0.00% 2 Missing ⚠️
src/game/common/system/buildassistant.cpp 0.00% 2 Missing ⚠️
src/game/common/gamemessage.cpp 0.00% 1 Missing ⚠️
src/game/common/gamemessage.h 0.00% 1 Missing ⚠️
src/game/logic/object/update/aiupdate.h 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1064      +/-   ##
===========================================
- Coverage     2.63%    2.61%   -0.02%     
===========================================
  Files          929      930       +1     
  Lines       106224   106952     +728     
  Branches     18062    18215     +153     
===========================================
  Hits          2799     2799              
- Misses      103021   103749     +728     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next batch.

src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Show resolved Hide resolved
src/game/client/ingameui.cpp Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
src/game/client/ingameui.cpp Show resolved Hide resolved
src/game/client/ingameui.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InGame text is smaller than in Original

Original

original

Thyme

thyme

Menu texts look identically sized.

@xezon
Copy link
Contributor

xezon commented Jan 30, 2024

Mouse over tool tip works
Mouse over tool tip over Mob works
Mouse over tool tip over SupplyWarehouse works
Selected player name and money shows in Observer bar
Select, deselect works
Build placement works
Floating text works (Hacker, Black Market)
World Animation works (tested on Supply Drop Zone money symbol)
Message text works
Military Briefing works
Move hint works
Area select works
Can't build messages work
Scrolling works
Power bar works
Money display works
Camera zoom works
Camera rotate works
Idle worker works

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briefing and mouse over over text size was fixed. Most things tested and worked. Enemy vehicle disguise hint text was not tested.

@jonwil jonwil merged commit eff5c4e into TheAssemblyArmada:develop Jan 30, 2024
7 checks passed
@jonwil jonwil deleted the ingameui4 branch January 30, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants