Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add details about ET setup #99

Merged
merged 11 commits into from
Aug 26, 2023

Conversation

esavary
Copy link
Contributor

@esavary esavary commented Aug 24, 2023

  • Split camera setup from calibration instructions.
  • Include images and details from the manual.

Copy link
Collaborator

@celprov celprov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please address my comments and then you can merge IMHO.

docs/data-collection/pre-session.md Outdated Show resolved Hide resolved

Please note that some of the images used in this section are sourced from the [Eye Tracker Instruction Manual](https://www.sr-research.com/support/attachment.php?aid=1376)

!!! warning "To ensure accurate performance and prevent minor drifts in the pupil and CR thresholds, perform the ET Setup 10-15 minutes after powering the ET on."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reader does not know at this point what is the CR threshold. Please introduce the abbreviation and explain (maybe earlier if there is somewhere else where this info would fit better in).

docs/data-collection/tear-down.md Outdated Show resolved Hide resolved
@@ -78,7 +78,7 @@
- [ ] **Retrieve ET recordings** (from {{ secrets.hosts.psychopy | default("███") }}):
- [ ] Insert a USB key into *{{ secrets.hosts.psychopy | default("███") }}* and save the experiment from AcqKnowledge.
- [ ] Upload to a pre-designated drop-box (e.g., using Dropbox)

- [ ] Press ‘CTRL+ALT+Q’ on the ET PC Tower to exit the EyeLink 1000 Plus Host PC application and click on the Shutdown button from the File Manager tool bar.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this on our setup? From what I remember, when I exited the Eyelink application, I was left with a black screen, so "click on the Shutdown button from the File Manager toolbar" would not have been possible.

docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved

![9-points_calibration](../assets/images/9-points_calibration.jpg)

- [ ] Two crosses should appear on the ET computer screen: one at the center of the pupil and the other at the center of the corneal reflection. If they're not visible, proceed sequentially with the following steps:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an image of where the two crosses should be if it is correctly setup? or maybe reference the focus.png picture as it shows nicely one cross

docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will finish later

docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments, still need to go through the end

docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/pre-session.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/tear-down.md Outdated Show resolved Hide resolved
Co-authored-by: celprov <77437752+celprov@users.noreply.github.com>
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
docs/data-collection/scanning-notes.md Outdated Show resolved Hide resolved
@oesteban
Copy link
Collaborator

I'm going to merge, but I will send a PR following up because I've noticed the added details are not in the right place of the SOPs (at this point, the participant has not arrived yet).

@oesteban oesteban merged commit f72c876 into TheAxonLab:mkdocs Aug 26, 2023
oesteban added a commit that referenced this pull request Aug 26, 2023
Addresses the problems introduced in #99.
@esavary esavary deleted the patch-ET-documentation branch August 28, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants