Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using skip sometimes skips 2 songs. #12

Closed
gh0s7w4r10rd opened this issue May 10, 2017 · 4 comments · Fixed by #90
Closed

Using skip sometimes skips 2 songs. #12

gh0s7w4r10rd opened this issue May 10, 2017 · 4 comments · Fixed by #90
Labels
🐞 Bug Something isn't working with Bastion Discord.js Issue Issue with discord.js library

Comments

@gh0s7w4r10rd
Copy link
Member

It's been happening since Bastion v2.0.0. In discord.js support server i found that it's bug in discord.js v11.1.0.

@iamtraction iamtraction added the 🐞 Bug Something isn't working with Bastion label May 10, 2017
@iamtraction
Copy link
Member

iamtraction commented May 10, 2017

When the skip command is ran, it calls the dispatcher.end() method (with reason user), but sometimes it gets called 2 times (the first reason being user and the second one being undefined). And as I tested further, I found that it happens in a specific pattern, like, using the skip command the first time dispatcher.end() is called two times, and the next time it's called only once, the third time it's again called two times, and it goes on like that. I don't think it's an issue with the code as it was working fine before updating the d.js lib to v11.1.

Code reference: play.js

@gh0s7w4r10rd
Copy link
Member Author

@iamtraction iamtraction added the Discord.js Issue Issue with discord.js library label Jul 6, 2017
@iamtraction iamtraction added the Hacktoberfest This issue or pull request will be counted towards DigitalOcean's Hacktoberfest label Oct 13, 2017
@iamtraction
Copy link
Member

This issue has been fixed in Discord.js v12 (unreleased). Will have to wait until it's released for this issue to get fixed, because can't use under development branch of Discord.js in production. Until then, sorry for the inconvenience.

discordjs/discord.js#1387

@iamtraction iamtraction removed the Hacktoberfest This issue or pull request will be counted towards DigitalOcean's Hacktoberfest label Nov 4, 2017
@iamtraction iamtraction mentioned this issue Jan 21, 2018
9 tasks
@iamtraction
Copy link
Member

Isn't fixed in linux (tested in Debian 9.x). Was working in my test environment (Windows 10 1709 Build 16299.192)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working with Bastion Discord.js Issue Issue with discord.js library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants