Add a wrapper around TrackedDeviceIndex_t. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheButlah
requested changes
Jan 22, 2023
src/lib.rs
Outdated
| #[repr(transparent)] | ||
| pub struct TrackedDeviceIndex(pub sys::TrackedDeviceIndex_t); | ||
| impl TrackedDeviceIndex { | ||
| pub const fn new(index: sys::TrackedDeviceIndex_t) -> Option<Self> { |
There was a problem hiding this comment.
I would opt for a result here instead.
There was a problem hiding this comment.
Not resolving yet, as I've only changed it to Result<Self, ()> since I don't have a good error type for this yet.
Answer might be to make a unit struct that has conversions into relevant error types eventually.
TheButlah
reviewed
Feb 11, 2023
TheButlah
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll rebase #8 and #10 on top of this one once this looks good.