Skip to content
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.

Remove the success field from responses #48

Open
mjs opened this issue Jan 9, 2018 · 4 comments
Open

Remove the success field from responses #48

mjs opened this issue Jan 9, 2018 · 4 comments

Comments

@mjs
Copy link
Member

mjs commented Jan 9, 2018

This field is redundant and less meaningful than the HTTP status code.

This can't be done until the Cacophonometer app stops relying on this field

@mjs
Copy link
Member Author

mjs commented Aug 7, 2018

@jackodsteel
Copy link
Contributor

jackodsteel commented May 2, 2019

Removal from Cacophonometer included in this PR:
https://github.com/TheCacophonyProject/cacophonometer/pull/42

@jackodsteel
Copy link
Contributor

Note still needs to be removed from the web UI:
TheCacophonyProject/cacophony-browse#14

@mjs
Copy link
Member Author

mjs commented May 7, 2019

Very cool to see this moving forward. We can't remove it from the API server until we're sure that all cacophonometers have been upgraded to a sufficiently new version. There are also some other clients (e.g. the cptv-download.py) which may need to be adjusted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants