Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the shaders after the shader program Creation #127

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Delete the shaders after the shader program Creation #127

merged 1 commit into from
Oct 5, 2019

Conversation

Isho312
Copy link
Contributor

@Isho312 Isho312 commented Sep 15, 2019 •
edited
Loading

After successfully creating the shader program, the shaders should be deleted since they're probably not needed anymore.
the leaks where discovered in #125

@LovelySanta
Copy link
Collaborator

It should indeed be deleted as the shader (and the id) is only present inside the scope of theOpenGLShader::Compile(...) function.

@LovelySanta LovelySanta added the Impact:Bug Unintended behaviour label Sep 15, 2019
@CleverSource CleverSource mentioned this pull request Sep 15, 2019
Closed
5 tasks
@LovelySanta LovelySanta added this to Bugfixes (awaiting merge) in Community additions Sep 15, 2019
@LovelySanta LovelySanta merged commit 5509204 into TheCherno:master Oct 5, 2019
Community additions automation moved this from Bugfixes (awaiting merge) to Merged PR's Oct 5, 2019
@Isho312 Isho312 deleted the memory-leaks-patch_shaders branch April 12, 2020 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Impact:Bug Unintended behaviour
Projects
Community additions
  
Merged PR's
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Isho312 @LovelySanta